Skip to content

Updating documentation to use Envoy API v3.#586

Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom
mum4k:docs-api-v2-to-v3
Dec 8, 2020
Merged

Updating documentation to use Envoy API v3.#586
mum4k merged 1 commit intoenvoyproxy:masterfrom
mum4k:docs-api-v2-to-v3

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Dec 3, 2020

Verified that an Envoy built after 588d9344b31e6544869547c4bcd359b3b0f1d4cf can load the configuration from the documents.

Also:

  • fixing one typo in the documentation.
  • cosmetic changes of enum values to uppercase form.

Works on #580

Signed-off-by: Jakub Sobon mumak@google.com

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k requested a review from oschaaf December 3, 2020 05:08
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Dec 3, 2020
@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Dec 3, 2020

@oschaaf I am a bit suspicious of the fact that I only found a single document location that needed an update. Please point me to others if I missed any.

@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Dec 3, 2020

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: test_gcc (failed build)

🐱

Caused by: a #586 (comment) was created by @mum4k.

see: more, trace.

Copy link
Copy Markdown
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@mum4k mum4k merged commit 90af260 into envoyproxy:master Dec 8, 2020
@mum4k mum4k deleted the docs-api-v2-to-v3 branch December 8, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants