Migrating config for benchmark tests to Envoy API v3.#585
Merged
oschaaf merged 1 commit intoenvoyproxy:masterfrom Dec 3, 2020
mum4k:bench-api-v2-to-v3
Merged
Migrating config for benchmark tests to Envoy API v3.#585oschaaf merged 1 commit intoenvoyproxy:masterfrom mum4k:bench-api-v2-to-v3
oschaaf merged 1 commit intoenvoyproxy:masterfrom
mum4k:bench-api-v2-to-v3
Conversation
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@eric846 Please review and assign back to me once done. |
oschaaf
approved these changes
Dec 3, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified the benchmark tests successfully load this configuration after updating Envoy to commit
588d9344b31e6544869547c4bcd359b3b0f1d4cf.Summary of performed changes:
configtotyped_configand listing the correct type.clustersstanza tov3.Works on #580
Signed-off-by: Jakub Sobon mumak@google.com