Skip to content

Migrating config for benchmark tests to Envoy API v3.#585

Merged
oschaaf merged 1 commit intoenvoyproxy:masterfrom
mum4k:bench-api-v2-to-v3
Dec 3, 2020
Merged

Migrating config for benchmark tests to Envoy API v3.#585
oschaaf merged 1 commit intoenvoyproxy:masterfrom
mum4k:bench-api-v2-to-v3

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Dec 3, 2020

Verified the benchmark tests successfully load this configuration after updating Envoy to commit 588d9344b31e6544869547c4bcd359b3b0f1d4cf.

Summary of performed changes:

  • changing config to typed_config and listing the correct type.
  • structural changes to update clusters stanza to v3.
  • changing filter names to ones that match extension names in extensions_build_config.bzl.
  • cosmetic changes of enum values to uppercase form.

Works on #580

Signed-off-by: Jakub Sobon mumak@google.com

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k requested review from eric846 and oschaaf December 3, 2020 04:46
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Dec 3, 2020
@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Dec 3, 2020

@eric846 Please review and assign back to me once done.

Copy link
Copy Markdown
Contributor

@eric846 eric846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oschaaf
Copy link
Copy Markdown
Member

oschaaf commented Dec 3, 2020

Merging this so I can pull these changes into #575 (@mum4k is OK with it on the premise that all reviewers are happy, which is the case).

@oschaaf oschaaf merged commit 31b7857 into envoyproxy:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants