Migrating configs of integration tests to Envoy API v3.#583
Merged
mum4k merged 4 commits intoenvoyproxy:masterfrom Dec 2, 2020
mum4k:integ-api-v2-to-v3
Merged
Migrating configs of integration tests to Envoy API v3.#583mum4k merged 4 commits intoenvoyproxy:masterfrom mum4k:integ-api-v2-to-v3
mum4k merged 4 commits intoenvoyproxy:masterfrom
mum4k:integ-api-v2-to-v3
Conversation
Adding `test_request_source_plugin.py` as a dependency of the `integration_test` py_binary. Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@eric846 please review and assign back to me once done. |
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Contributor
|
LGTM |
oschaaf
approved these changes
Dec 2, 2020
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
LGTM, but to make sure it's not left out by accident: will https://github.com/envoyproxy/nighthawk/blob/master/benchmarks/configurations/envoy_proxy.yaml go in a follow up?
Collaborator
Author
|
Confirming that https://github.com/envoyproxy/nighthawk/blob/master/benchmarks/configurations/envoy_proxy.yaml will be addressed in the next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified that all integration tests pass after updating Envoy to commit
588d9344b31e6544869547c4bcd359b3b0f1d4cf, so this PR unblocks #575. Our next steps will be adding a good warning and a compatibility flag for users of Nighthawk. If they do send configs with Envoy API v2, we will break by default, but allow them to continue with the compatibility flag.Summary of performed changes:
configtotyped_configand listing the correct type.tls_contexttotransport_socket.autotoAUTO.Also:
--tls-contextflag since this behavior is mirrored by one of the edited integration tests.test_request_source_plugin.pyintegration test as a dependency of theintegration_testpy_binary which was forgotten before.Works on #580
Signed-off-by: Jakub Sobon mumak@google.com