Fix integration tests when running with IPv6.#579
Merged
mum4k merged 3 commits intoenvoyproxy:masterfrom Dec 2, 2020
mum4k:fix-ipv6-integration
Merged
Fix integration tests when running with IPv6.#579mum4k merged 3 commits intoenvoyproxy:masterfrom mum4k:fix-ipv6-integration
mum4k merged 3 commits intoenvoyproxy:masterfrom
mum4k:fix-ipv6-integration
Conversation
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@qqustc please review and assign back to me once done. |
Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
previously approved these changes
Dec 1, 2020
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
one question about the change to the wakeup period while polling test server, otherwise LGTM
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@oschaaf please take another look after the latest changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't run integration tests in IPv6 mode on CI (See #578). As a result some of the test expectations became invalid.
Also:
man 3 inet_pton, the address::/0isn't valid, while::is.Signed-off-by: Jakub Sobon mumak@google.com