Skip to content

CI: make clang-tidy always pass. #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mum4k merged 2 commits into from
Nov 11, 2020
Merged

CI: make clang-tidy always pass. #570

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e46ade
CI: make clang-tidy always pass.
oschaaf Nov 10, 2020
0790741
review feedback
oschaaf Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function do_test() {
}

function do_clang_tidy() {
ci/run_clang_tidy.sh
ci/run_clang_tidy.sh || true

@mum4k mum4k Nov 11, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here pointing to the issue about a long term fix?

@oschaaf oschaaf Nov 11, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0790741

}

function do_unit_test_coverage() {
Expand Down