Skip to content

chore: enhance naming of bool maybeSendErrorReply#568

Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom
kushthedude:namingEnh
Nov 11, 2020
Merged

chore: enhance naming of bool maybeSendErrorReply#568
mum4k merged 1 commit intoenvoyproxy:masterfrom
kushthedude:namingEnh

Conversation

@kushthedude
Copy link
Copy Markdown
Contributor

Signed-off-by: Kush Trivedi kushthedude@gmail.com
fixes #558

Signed-off-by: Kush Trivedi <kushthedude@gmail.com>
Copy link
Copy Markdown
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

Copy link
Copy Markdown
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mum4k mum4k merged commit 45c6205 into envoyproxy:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server extensions: enhance naming of bool maybeSendErrorReply()

3 participants