Avoid crash with the experimental fortio pedantic formatter#544
Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom Sep 18, 2020
Merged
Avoid crash with the experimental fortio pedantic formatter#544mum4k merged 1 commit intoenvoyproxy:masterfrom
mum4k merged 1 commit intoenvoyproxy:masterfrom
Conversation
formatter factory when to construct the new formatter. Sorry! - Amends a pre-existing test to avoid regression when adding new output formats in the future - Fix the issue Fixes envoyproxy#543 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
approved these changes
Sep 18, 2020
Collaborator
mum4k
left a comment
mum4k
left a comment
There was a problem hiding this comment.
Thank you for adding the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot the last step, which is to actually teach the output
formatter factory when to construct the new formatter. Sorry!
output formats in the future
statement.
Fixes #543
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com