Switch dynamic delay and time-tracking to use FilterConfigurationBase.#540
Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom Sep 18, 2020
Merged
Conversation
Second step in unifying configuration handling accross extensions: make these two extensions inherit from and use FilterConfigurationBase. Split out from envoyproxy#512 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
9 tasks
Collaborator
|
@qqustc please review and assign back to me once done. |
Member
Author
There is pre-existing testing in place, this should be ok in that regard |
mum4k
approved these changes
Sep 18, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step in unifying configuration handling across extensions:
make these two extensions inherit from and use FilterConfigurationBase.
Fix POST handling.
Split out from #512
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com