Enhance end-to-end test for POST requests with an entity body.#532
Merged
dubious90 merged 4 commits intoenvoyproxy:masterfrom Sep 14, 2020
Merged
Conversation
Make the end-to-end test for POST handling cover all extensions. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
9 tasks
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
dubious90
reviewed
Sep 14, 2020
Contributor
dubious90
left a comment
dubious90
left a comment
There was a problem hiding this comment.
Two really small comments.
| 'filter_configs', | ||
| ["{}", "{static_delay: \"0.01s\"}", "{emit_previous_request_delta_in_response_header: \"aa\"}"]) | ||
| def test_request_body_gets_transmitted(http_test_server_fixture, filter_configs): | ||
| """Test request body transmission with. |
Contributor
There was a problem hiding this comment.
I think this comment is incomplete?
|
|
||
| upload_bytes = 1024 * 1024 * 3 | ||
| # TODO(#531): The dynamic-delay extension hangs unless we lower the request entity body size. | ||
| if "static_delay" in filter_configs: |
Contributor
There was a problem hiding this comment.
How do you feel about combining this with the above line and making it a ternary, rather than an if condition?
My 2 cents is that as is, it's possible to scan this and not notice that upload_bytes has changed from its original value.
dubious90
added
waiting-for-changes
…g-integration-test Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Member
Author
|
@dubious90 thanks for the review; I applied corresponding changes in 467dd6b |
oschaaf
added
waiting-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the end-to-end test for POST handling cover all extensions.
Split out from #512
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com