Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Both API and implementation stability are important to Nighthawk. Since the API

* Generally Nighthawk mirrors [Envoy's policy](https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#pr-review-policy-for-maintainers) with respect to maintainer review policy.
* See [OWNERS.md](OWNERS.md) for the current list of maintainers.
* It is helpful if you apply the label `waiting-for-review` to any PRs that are ready to be reviewed by a maintainer.
* Reviewers will change the label to `waiting-for-changes` when responding.

# DCO: Sign your work

Expand Down
4 changes: 3 additions & 1 deletion MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ Envoy internals.
- New features should be added to the [version history](docs/root/version_history.md).
- Breaking changes to the [protobuf APIs](api/) are not allowed.
- When merging, clean up the commit message so we get a nice history. By default,
github will compile a messages from all the commits that are squashed.
github will compile a message from all the commits that are squashed.
The PR title and description should be a good starting point for the final commit message.
(If it is not, it may be worth asking the PR author to update the description).
- Make sure that the DCO signoff is included in the final commit message.
- As a convention, it is appropriate to exclude content in the PR description that occurs after the signoff.

## Updates to the Envoy dependency

Expand Down
2 changes: 2 additions & 0 deletions OWNERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ routing PRs, questions, etc. to the right place.
* Envoy internals and architecture.
* Jakub Sobon ([mum4k](https://github.com/mum4k)) (mumak@google.com)
* APIs, general functionality and miscellany.
* Nathan Perry ([dubious90](https://github.com/dubious90)) (nbperry@google.com)
* APIs and general functionality.