Skip to content

Update Envoy to 13da8f415c372e7fde3b0105f58f57348e84acb5#412

Merged
mum4k merged 4 commits intoenvoyproxy:masterfrom
oschaaf:envoy-dep-update-27
Jul 18, 2020
Merged

Update Envoy to 13da8f415c372e7fde3b0105f58f57348e84acb5#412
mum4k merged 4 commits intoenvoyproxy:masterfrom
oschaaf:envoy-dep-update-27

Conversation

@oschaaf
Copy link
Copy Markdown
Member

@oschaaf oschaaf commented Jul 17, 2020

Switches to c++17

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Jul 17, 2020
-modernize-use-nodiscard
-modernize-concat-nested-namespaces

Better to postpone these, and take them on separately, once
we're sure that Envoy won't revert back to c++14.

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
mum4k previously approved these changes Jul 17, 2020
@mum4k
Copy link
Copy Markdown
Collaborator

mum4k commented Jul 17, 2020

Waiting for CI.

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@mum4k mum4k merged commit d614a41 into envoyproxy:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants