Update Envoy to 12b3d2c2ffa582507e5d6dd34632b2b990f1b195#376
Merged
mum4k merged 7 commits intoenvoyproxy:masterfrom Jun 22, 2020
Merged
Update Envoy to 12b3d2c2ffa582507e5d6dd34632b2b990f1b195#376mum4k merged 7 commits intoenvoyproxy:masterfrom
mum4k merged 7 commits intoenvoyproxy:masterfrom
Conversation
Has some mundane changes related to header construction. Switches us to clang-10, which hopefully addresses envoyproxy#362 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
- Fix superfluous initializers in the rate limiter code. - Suppress modernize-avoid-bind in sequencer_test.cc. (clang-tidy's auto generated suggested fix fails to build) Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Need to analyse why this is needed yet. Assuming everything is allright, dropping the threshold for now. Potential causes: - clang-tidy-10 is more accurate - we dropped a few lines of code. If we borderlined. this induces a lower coverage percentage threshold requirement. - something else. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Member
Author
|
The coverage threshold had to be lowered because of small changes, probably related to clang-10. For example, compare the new factories impl coverage with the latest from master. I think that makes sense, and that the new version is more accurate. So lowering the coverage threshold seems |
The attempt to do it more fine-grained failed. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
approved these changes
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes in this Update:
(clang-tidy's auto generated suggested fix fails to build)
AddFilter()in the server filter tests.This avoids asserts being triggered by the integration test framework
as deprecated fields for which support was dropped get generated
otherwise.
Hopefully addresses #362 by producing more reliable and accurate
coverage reports.
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com
prerequisite before merge
impact on NH, if any. Possibly we need to move away some code
from deprecated cluster field usage. (filed Move away from using hidden_envoy_deprecated_hosts #377)