Add zipf distributing ratelimiter#251
Merged
mum4k merged 45 commits intoenvoyproxy:masterfrom Jan 14, 2020
Merged
Conversation
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Prerequisite to envoyproxy#217 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…te-limiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…te-limiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…te-limiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…-linear-rate-limiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…te-limiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
This reverts commit 324a4ee. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Member
Author
|
Note to self: address first round of comment from #218 here before proceeding with review |
2 tasks
…-ratelimiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…-ratelimiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…-ratelimiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…-ratelimiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
requested changes
Jan 7, 2020
source/common/rate_limiter_impl.h
Outdated
| * If NDEBUG is defined and either or both of these parameters take invalid | ||
| * values, the behavior of the class is undefined. | ||
| */ | ||
| ZipfRateLimiterImpl(RateLimiterPtr&& rate_limiter, bool deterministic, double q = 2.0, |
Collaborator
There was a problem hiding this comment.
I believe we had some open comments for the API and its documentation here in the original PR where this was introduced before we split it out. Would you mind resolving those comments before we proceed?
Member
Author
There was a problem hiding this comment.
Done, addressed the prior feedback round in 10dbc29
mum4k
added
waiting-for-changes
Address feedback given before the PR split Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf
added
waiting-for-review
…-ratelimiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
…-ratelimiter Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
approved these changes
Jan 13, 2020
Collaborator
|
Could you update the description of this PR? Unless there is still something blocking this? |
mum4k
added
waiting-for-changes
Member
Author
Done! |
oschaaf
added
waiting-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a probabilistic filtering rate limiter, which will suppress an underlying rate limiter's pacing using a zipf distribution.
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com