Skip to content

Update Envoy dep for access to enableHRTimer()#222

Merged
oschaaf merged 7 commits intoenvoyproxy:masterfrom
oschaaf:update-envoy-dep-8
Dec 13, 2019
Merged

Update Envoy dep for access to enableHRTimer()#222
oschaaf merged 7 commits intoenvoyproxy:masterfrom
oschaaf:update-envoy-dep-8

Conversation

@oschaaf
Copy link
Copy Markdown
Member

@oschaaf oschaaf commented Dec 3, 2019

Prerequisite to #217

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

Prerequisite to envoyproxy#217

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@mum4k mum4k self-requested a review December 5, 2019 13:26
Copy link
Copy Markdown
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, htuch to approve

@mum4k
Copy link
Copy Markdown
Collaborator

mum4k commented Dec 5, 2019

/assign htuch

@oschaaf
Copy link
Copy Markdown
Member Author

oschaaf commented Dec 5, 2019

Note: the prerequisite in Envoy changed to envoyproxy/envoy#9229 as we have had to back out the first attempt. It probably makes sense to update this PR to use the forthcoming Envoy revision that has that, after it lands.. Sorry, should have remarked about that earlier here.

@htuch htuch added the waiting label Dec 10, 2019
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Copy link
Copy Markdown
Member Author

oschaaf commented Dec 13, 2019

This is ready for review (again).
I updated to the Envoy revision that has enableHRTimer() and also amended what broke while doing so.

Copy link
Copy Markdown
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@oschaaf oschaaf mentioned this pull request Dec 13, 2019
1 task
@oschaaf oschaaf merged commit 89dec9e into envoyproxy:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants