cache: clean up TTL logic after v2 removal#425
Merged
Conversation
Now that V2 has been removed, we can clean up a lot of the awkward handling of TTL that was required due to the fields not existing in V2. Signed-off-by: Snow Pettersen <snowp@lyft.com>
alecholmez
approved these changes
Apr 21, 2021
Contributor
alecholmez
left a comment
alecholmez
left a comment
There was a problem hiding this comment.
This is cool, I wonder if this will help TTL in incremental as well. Less things to worry about
Contributor
Author
|
Should make it a little bit easier and also a lot clearer what's actually going on |
Contributor
|
Sounds good to me 😄 this looks great. Though I can't approve for merge haha. Maybe @jessicayuen can? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Contributor
|
@snowp wanna merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that V2 has been removed, we can clean up a lot of the awkward handling of TTL
that was required due to the fields not existing in V2.
Signed-off-by: Snow Pettersen snowp@lyft.com