Fix panic in case the resourceType is not know by the caches #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Diego dos Santos <[email protected]>
alandiegosantos
force-pushed
the
adiegodossan/fix_panic
branch
from
66bced6 to
357178f
Compare
Signed-off-by: Alan Diego <[email protected]>
valerian-roche
approved these changes
Oct 31, 2024
alecholmez
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MuxCache and the LinearCache relies on sending a nil value in the channel to notify that the stream should be closed. This behaviour causes the xds server to panic because the code expects that the conversion succeeds, otherwise it panics.
This MR adds a check in the beginning to check if value is
nil. If it is, close the stream, otherwise, proceed as usual.