fix bug with grpcroute mirror filter#8541
Merged
jukie merged 4 commits intoenvoyproxy:mainfrom Mar 23, 2026
Merged
Conversation
Signed-off-by: Adam Buran <aburan@roblox.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Member
|
can you add test and release notes for this? |
Signed-off-by: Adam Buran <aburan@roblox.com>
Signed-off-by: Adam Buran <aburan@roblox.com>
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8541 +/- ##
==========================================
+ Coverage 74.16% 74.18% +0.01%
==========================================
Files 242 242
Lines 37804 37821 +17
==========================================
+ Hits 28039 28056 +17
- Misses 7809 7810 +1
+ Partials 1956 1955 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
approved these changes
Mar 23, 2026
jukie
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(provider): add RequestMirror backendRef indexing for GRPCRoute
What this PR does / why we need it:
The GRPCRoute backend indexer (backendGRPCRouteIndexFunc) is missing RequestMirror filter support. It only iterates over rule.BackendRefs and never inspects rule.Filters for RequestMirror entries. Since the indexer tells the resource collector which services a route depends on, the mirror target service is never loaded into the translation resource map. When validateBackendRefService calls t.GetService(), the service isn't found and the route is rejected with "service not found" — even though the service exists in the cluster.
This is the same bug as #5495 (for HTTPRoute), which was fixed in #5497, but the fix was only applied to backendHTTPRouteIndexFunc and never carried over to backendGRPCRouteIndexFunc.
The fix adds the same RequestMirror filter iteration to backendGRPCRouteIndexFunc that already exists in backendHTTPRouteIndexFunc, appending the mirror's BackendRef to the indexed backend refs.
Which issue(s) this PR fixes:
Fixes #6875
Release Notes: Yes