Skip to content

api: make ConnectionLimit.Value optional#8478

Merged
jukie merged 3 commits into
envoyproxy:mainfrom
felipesabadini:fix/connection-limit-optional-value
Mar 11, 2026
Merged

api: make ConnectionLimit.Value optional#8478
jukie merged 3 commits into
envoyproxy:mainfrom
felipesabadini:fix/connection-limit-optional-value

fix: add CEL rule to require value when closeDelay is set

e9b5d44
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2026 in 1s

74.12% (target 60.00%)

View this Pull Request on Codecov

74.12% (target 60.00%)

Details

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.12%. Comparing base (a470576) to head (e9b5d44).

Files with missing lines Patch % Lines
internal/xds/translator/listener.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8478      +/-   ##
==========================================
- Coverage   74.13%   74.12%   -0.01%     
==========================================
  Files         242      242              
  Lines       37579    37581       +2     
==========================================
- Hits        27859    27858       -1     
- Misses       7778     7780       +2     
- Partials     1942     1943       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.