Skip to content

fix e2e test panic #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 1 commit into from
Jan 30, 2026
+3 −3
Merged

fix e2e test panic #8109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/tests/ext_auth_http_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ var HTTPExtAuthTest = suite.ConformanceTest{
req := http.MakeRequest(t, &expectedResponse, gwAddr, "HTTP", "http")
cReq, cResp, err := suite.RoundTripper.CaptureRoundTrip(req)
if err != nil {
t.Errorf("failed to get expected response: %v", err)
t.Fatalf("failed to get expected response: %v", err)
Copy link
Copy Markdown
Member

@zirain zirain Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this like the diff between assert with require?

Copy link
Copy Markdown
Member Author

@zhaohuabing zhaohuabing Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fatalf fails the current subtest immediately without executing the remaining parts of the it.

}
if err := http.CompareRoundTrip(t, &req, cReq, cResp, expectedResponse); err != nil {
t.Errorf("failed to compare request and response: %v", err)
Expand Down Expand Up @@ -133,7 +133,7 @@ var HTTPExtAuthTest = suite.ConformanceTest{
req := http.MakeRequest(t, &expectedResponse, gwAddr, "HTTP", "http")
cReq, cResp, err := suite.RoundTripper.CaptureRoundTrip(req)
if err != nil {
t.Errorf("failed to get expected response: %v", err)
t.Fatalf("failed to get expected response: %v", err)
}
if err := http.CompareRoundTrip(t, &req, cReq, cResp, expectedResponse); err != nil {
t.Errorf("failed to compare request and response: %v", err)
Expand Down Expand Up @@ -163,7 +163,7 @@ var HTTPExtAuthTest = suite.ConformanceTest{
req := http.MakeRequest(t, &expectedResponse, gwAddr, "HTTP", "http")
cReq, cResp, err := suite.RoundTripper.CaptureRoundTrip(req)
if err != nil {
t.Errorf("failed to get expected response: %v", err)
t.Fatalf("failed to get expected response: %v", err)
}
if err := http.CompareRoundTrip(t, &req, cReq, cResp, expectedResponse); err != nil {
t.Errorf("failed to compare request and response: %v", err)
Expand Down