Skip to content

feat: Ignore ready and stats listener metrics in shutdown manager calculation#7985

Merged
zirain merged 8 commits into
envoyproxy:mainfrom
zirain:fix-7947
Jan 28, 2026
Merged

feat: Ignore ready and stats listener metrics in shutdown manager calculation#7985
zirain merged 8 commits into
envoyproxy:mainfrom
zirain:fix-7947

comment for worker thread

2d9ad56
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2026 in 0s

73.90% (target 60.00%)

View this Pull Request on Codecov

73.90% (target 60.00%)

Details

Codecov Report

❌ Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.90%. Comparing base (15b62c0) to head (2d9ad56).

Files with missing lines Patch % Lines
internal/cmd/envoy/shutdown_manager.go 58.13% 15 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7985   +/-   ##
=======================================
  Coverage   73.89%   73.90%           
=======================================
  Files         237      237           
  Lines       35831    35847   +16     
=======================================
+ Hits        26478    26491   +13     
  Misses       7496     7496           
- Partials     1857     1860    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.