fix: set OpenTelemetry Tracer/Accesslog default protocol to GRPC#7694
fix: set OpenTelemetry Tracer/Accesslog default protocol to GRPC#7694zirain merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7694 +/- ##
==========================================
- Coverage 72.36% 72.30% -0.06%
==========================================
Files 233 234 +1
Lines 34343 34487 +144
==========================================
+ Hits 24851 24937 +86
- Misses 7712 7763 +51
- Partials 1780 1787 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
agree for now, but soon we'll get http in envoyproxy/envoy#42445 cc @arkodg |
we can still check the configuration and enable h2 when is a grpc backend. |
|
/retest |
| return nil, err | ||
| } | ||
|
|
||
| // EG currently support OTel tracing only, change protocol to GRPC. |
There was a problem hiding this comment.
thanks, can we do the same for metrics and access logs as well
There was a problem hiding this comment.
update for accesslog.
Metrics is [done].(
| namespace: envoy-gateway-system | ||
| name: tracing/backend/-1 | ||
| protocol: TCP | ||
| protocol: GRPC |
There was a problem hiding this comment.
can we also add a test case in xds lib as well
There was a problem hiding this comment.
zirain
changed the title
|
/retest |
…oyproxy#7694) * fix: set OpenTelemetry Tracer default protocol to GRPC Signed-off-by: zirain <zirain2009@gmail.com> * e2e Signed-off-by: zirain <zirain2009@gmail.com> * fix Signed-off-by: zirain <zirain2009@gmail.com> * accesslog Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Matt Miller <millermatt@outlook.com>
4 participants
fixes: #7690
Currently, EG support GRPC OpenTelemetry Tracer only, it should be better to change the default to GRPC.