ci: add tests for Kubernetes 1.34#7680
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7680 +/- ##
==========================================
+ Coverage 72.38% 72.40% +0.02%
==========================================
Files 234 234
Lines 34562 34562
==========================================
+ Hits 25016 25023 +7
+ Misses 7756 7750 -6
+ Partials 1790 1789 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, thanks |
271a9eb to
f31fd88
Compare
Head branch was pushed to by a user without write access
|
@zirain Is anything missing we need to proceed? I see some of the CI jobs failed but these look unrelated. |
| ipFamily: dual # only run dual test on latest version to save time | ||
| profile: gateway-namespace-mode | ||
| - version: v1.33.1 | ||
| - version: v1.34.0 |
There was a problem hiding this comment.
nit: Could we target the latest kubernetes version 1.34.2?
There was a problem hiding this comment.
for https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml this should be v1.34.1
There was a problem hiding this comment.
Could we target the latest kubernetes version 1.34.2?
The versions will be used as container tag of the kind node image which has no 1.34.1/1.34.2 builds yet.
|
can you also update here? |
6494bbb
| ipFamily: ipv6 # only run ipv6 test on this version to save time | ||
| profile: default | ||
| # TODO: this's IPv4 first, need a way to test IPv6 first. | ||
| - version: v1.33.1 | ||
| - version: v1.34.0 |
There was a problem hiding this comment.
| - version: v1.34.0 | |
| - version: v1.34.1 |
There was a problem hiding this comment.
The workflow will attempt to provision a kind cluster with that version and there is no 1.34.1/1.34.2 kind release yet.
There was a problem hiding this comment.
v1.34.0 and v1.34.2 exist as of today.
There was a problem hiding this comment.
Good catch. Updated to 1.34.2
Envtest only has1.34.1 so we can't sync these (yet).
e233346 to
16a6005
Compare
* add Kubernetes 1.34 conformance and e2e tests * drop Kubernetes 1.30 conformance and e2e tests * update compatibility matrix Signed-off-by: Clemens Beck <mail@beckcl.dev>
Signed-off-by: Clemens Beck <mail@beckcl.dev>
Signed-off-by: Clemens Beck <mail@beckcl.dev>
16a6005 to
fedc0f1
Compare
The error message returned by the API server now escapes the quotes of "null". Fixed by splitting the expected error string into smaller strings to keep compatible with K8s <1.34. Signed-off-by: Clemens Beck <mail@beckcl.dev>
|
/retest |
|
/retest |
* ci: add tests for Kubernetes 1.34 * add Kubernetes 1.34 conformance and e2e tests * drop Kubernetes 1.30 conformance and e2e tests * update compatibility matrix Signed-off-by: Clemens Beck <mail@beckcl.dev> * bump envtest K8s version Signed-off-by: Clemens Beck <mail@beckcl.dev> * update to K8s 1.34.2 Signed-off-by: Clemens Beck <mail@beckcl.dev> * fix CEL test on K8s 1.34 The error message returned by the API server now escapes the quotes of "null". Fixed by splitting the expected error string into smaller strings to keep compatible with K8s <1.34. Signed-off-by: Clemens Beck <mail@beckcl.dev> --------- Signed-off-by: Clemens Beck <mail@beckcl.dev> Co-authored-by: Clemens Beck <mail@beckcl.dev> Signed-off-by: Matt Miller <millermatt@outlook.com>
What type of PR is this?
Run e2e and conformance tests on K8s 1.34 in CI.
What this PR does / why we need it:
Update the version matrix to give confidence in the most recent K8s version. Also updates the docs hosted at https://gateway.envoyproxy.io/news/releases/matrix/.
Which issue(s) this PR fixes:
No linked issue.
Release Notes: No