Skip to content

bechmark: fix cpu sampling #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 1 commit into from
Nov 24, 2025
Merged

bechmark: fix cpu sampling #7581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions test/benchmark/suite/report.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ const (
dataPlaneMemQL = `container_memory_working_set_bytes{namespace="envoy-gateway-system", container="envoy"}/1024/1024`
dataPlaneCPUQLFormat = `rate(container_cpu_usage_seconds_total{namespace="envoy-gateway-system", container="envoy"}[%DURATIONs])*100`
DurationFormatter = "%DURATION"

benchmarkCPURateWindow = 30 * time.Second
)

// BenchmarkMetricSample contains sampled metrics and profiles data.
Expand Down Expand Up @@ -134,8 +136,15 @@ func (r *BenchmarkReport) sampleMetrics(ctx context.Context, sample *BenchmarkMe
}
// Sample cpu

// Get duration
durationSeconds := int(time.Since(startTime).Seconds())
// CPU usages is calculated based on the Kubernetes container_cpu_usage_seconds_total counter metric.
// We use a fixed window size of 30s for rate calculation. However, to ensure that we only capture
// metrics during the benchmark run period (and not before), if the benchmark run duration is
// less than the fixed window size,
durationSeconds := int(benchmarkCPURateWindow.Seconds())
elapsed := time.Since(startTime)
if elapsed < benchmarkCPURateWindow {
durationSeconds = int(elapsed.Seconds())
}
durationStr := fmt.Sprintf("%d", durationSeconds)
cpCPUQL := strings.ReplaceAll(controlPlaneCPUQL, DurationFormatter, durationStr)

Expand Down