Skip to content

chore(examples): fix extensionserver build #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2025
Merged

chore(examples): fix extensionserver build #7398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/envoy-ext-auth/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
IMAGE_PREFIX ?= envoyproxy/gateway-
APP_NAME ?= envoy-ext-auth
TAG ?= latest
GO_LDFLAGS ?=

.PHONY: docker-buildx
docker-buildx:
Expand Down
7 changes: 4 additions & 3 deletions examples/extension-server/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ $(tools.bindir)/%: $(tools.srcdir)/%/pin.go $(tools.srcdir)/%/go.mod
IMAGE_PREFIX ?= envoyproxy/gateway-
APP_NAME ?= extension-server
TAG ?= latest
GO_LDFLAGS ?=

.PHONY: docker-buildx
docker-buildx:
docker buildx build -f tools/docker/extension-server/Dockerfile . -t $(IMAGE_PREFIX)$(APP_NAME):$(TAG) --build-arg GO_LDFLAGS="$(GO_LDFLAGS)" --load
docker-buildx: build
docker buildx build -f tools/docker/extension-server/Dockerfile . -t $(IMAGE_PREFIX)$(APP_NAME):$(TAG) --load

build: generate manifests
mkdir -p bin
CGO_ENABLED=0 go build -o bin/extension-server ./cmd/extension-server
CGO_ENABLED=0 go build -o bin/extension-server -ldflags "$(GO_LDFLAGS)" ./cmd/extension-server

image: build
docker build -t extension-server:latest -f tools/docker/extension-server/Dockerfile .
Expand Down
4 changes: 2 additions & 2 deletions ...charts/extension-server/crds/generated/example.extensions.io_listenercontextexamples.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.17.1
controller-gen.kubebuilder.io/version: v0.19.0
name: listenercontextexamples.example.extensions.io
spec:
group: example.extensions.io
Expand All @@ -17,7 +17,7 @@ spec:
- name: v1alpha1
schema:
openAPIV3Schema:
description: ListenerContext provides an example extension policy context
description: ListenerContextExample provides an example extension policy context
resource.
properties:
apiVersion:
Expand Down
2 changes: 1 addition & 1 deletion examples/extension-server/internal/extensionserver/post_cluster_modify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (s *Server) PostClusterModify(ctx context.Context, req *pb.PostClusterModif
s.log.Info("found InferencePool for cluster modification",
slog.String("name", pool.GetName()),
slog.String("namespace", pool.GetNamespace()),
slog.Int("targetPortNumber", int(pool.Spec.TargetPortNumber)))
slog.Any("targetPorts", pool.Spec.TargetPorts))

inferencePoolConfigs = append(inferencePoolConfigs, &pool)
}
Expand Down
4 changes: 2 additions & 2 deletions examples/extension-server/internal/extensionserver/post_route_modify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (s *Server) PostRouteModify(ctx context.Context, req *pb.PostRouteModifyReq
s.log.Info("found InferencePool backend",
slog.String("name", pool.GetName()),
slog.String("namespace", pool.GetNamespace()),
slog.Int("targetPortNumber", int(pool.Spec.TargetPortNumber)))
slog.Any("targetPorts", pool.Spec.TargetPorts))
break
}
}
Expand Down Expand Up @@ -92,7 +92,7 @@ func (s *Server) PostRouteModify(ctx context.Context, req *pb.PostRouteModifyReq
slog.String("route_name", modifiedRoute.GetName()),
slog.String("inference_pool_name", inferencePool.GetName()),
slog.String("inference_pool_namespace", inferencePool.GetNamespace()),
slog.Int("target_port", int(inferencePool.Spec.TargetPortNumber)))
slog.Any("target_ports", inferencePool.Spec.TargetPorts))

return &pb.PostRouteModifyResponse{
Route: modifiedRoute,
Expand Down
8 changes: 6 additions & 2 deletions examples/extension-server/internal/extensionserver/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ func TestPostRouteModify_WithInferencePool(t *testing.T) {
"namespace": "default",
},
"spec": map[string]interface{}{
"targetPortNumber": 8000,
"targetPorts": []map[string]interface{}{
{"number": 8000},
},
"selector": map[string]interface{}{
"app": "vllm-llama3-8b-instruct",
},
Expand Down Expand Up @@ -188,7 +190,9 @@ func TestPostClusterModify_WithInferencePool(t *testing.T) {
"namespace": "default",
},
"spec": map[string]interface{}{
"targetPortNumber": 8000,
"targetPorts": []map[string]interface{}{
{"number": 8000},
},
"selector": map[string]interface{}{
"app": "vllm-llama3-8b-instruct",
},
Expand Down
1 change: 1 addition & 0 deletions examples/grpc-ext-proc/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
IMAGE_PREFIX ?= envoyproxy/gateway-
APP_NAME ?= grpc-ext-proc
TAG ?= latest
GO_LDFLAGS ?=

.PHONY: docker-buildx
docker-buildx:
Expand Down
1 change: 1 addition & 0 deletions examples/preserve-case-backend/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
IMAGE_PREFIX ?= envoyproxy/gateway-
APP_NAME ?= preserve-case-backend
TAG ?= latest
GO_LDFLAGS ?=

.PHONY: docker-buildx
docker-buildx:
Expand Down
1 change: 1 addition & 0 deletions examples/simple-extension-server/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
IMAGE_PREFIX ?= envoyproxy/gateway-
APP_NAME ?= simple-extension-server
TAG ?= latest
GO_LDFLAGS ?=

.PHONY: docker-buildx
docker-buildx:
Expand Down
1 change: 1 addition & 0 deletions examples/static-file-server/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
IMAGE_PREFIX ?= envoyproxy/gateway-
APP_NAME ?= static-file-server
TAG ?= latest
GO_LDFLAGS ?=

.PHONY: docker-buildx
docker-buildx:
Expand Down
Loading