-
Notifications
You must be signed in to change notification settings - Fork 592
add kube api linter #7303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kube api linter #7303
Conversation
37600b4 to
cf53708
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7303 +/- ##
==========================================
- Coverage 72.29% 72.29% -0.01%
==========================================
Files 231 231
Lines 34084 34084
==========================================
- Hits 24641 24640 -1
+ Misses 7670 7669 -1
- Partials 1773 1775 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5ff3ce3 to
811cfdc
Compare
|
For now just added few linters to integrate the ci workflow:
We call adjust the linters later according to the community need. |
|
cc @rikatz for additional guidance |
811cfdc to
a64e3c0
Compare
|
thanks @fabian4 , had a few questions
|
|
Hi @arkodg
|
a64e3c0 to
a3c69f1
Compare
|
@fabian4 It would be better if you can move those unrelated changes to a separated PR and rebase this one after it merged. |
a3c69f1 to
2955f2d
Compare
87aae83 to
6c05a1e
Compare
|
wait #7484 |
arkodg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
|
/retest |
Signed-off-by: fabian4 <[email protected]>
d2cbbd9 to
576b18b
Compare
What type of PR is this?
feat(lint): add kube api linter
What this PR does / why we need it:
add kube api linter
Which issue(s) this PR fixes:
Fixes #6546
Release Notes: Yes/No