Skip to content

Conversation

@fabian4
Copy link
Contributor

@fabian4 fabian4 commented Oct 22, 2025

What type of PR is this?

feat(lint): add kube api linter

What this PR does / why we need it:

add kube api linter

Which issue(s) this PR fixes:

Fixes #6546

Release Notes: Yes/No

@fabian4 fabian4 requested a review from a team as a code owner October 22, 2025 14:09
@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from 37600b4 to cf53708 Compare October 22, 2025 14:13
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.29%. Comparing base (c853061) to head (576b18b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7303      +/-   ##
==========================================
- Coverage   72.29%   72.29%   -0.01%     
==========================================
  Files         231      231              
  Lines       34084    34084              
==========================================
- Hits        24641    24640       -1     
+ Misses       7670     7669       -1     
- Partials     1773     1775       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabian4 fabian4 force-pushed the add_kubeapi_linter branch 5 times, most recently from 5ff3ce3 to 811cfdc Compare October 27, 2025 12:12
@fabian4
Copy link
Contributor Author

fabian4 commented Oct 27, 2025

For now just added few linters to integrate the ci workflow:

  • "conditions"
  • "nodurations"
  • "nonullable"
  • "notimestamp"
  • "statusoptional"

We call adjust the linters later according to the community need.
👉 https://github.com/kubernetes-sigs/kube-api-linter/blob/main/docs/linters.md

@arkodg
Copy link
Contributor

arkodg commented Oct 27, 2025

cc @rikatz for additional guidance

@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from 811cfdc to a64e3c0 Compare October 28, 2025 14:05
@arkodg
Copy link
Contributor

arkodg commented Oct 28, 2025

thanks @fabian4 , had a few questions

  • curious why the non /api file fixes were needed
  • can you enable all, add the failures in a GH issue, so we can make sure to enable all and fix the issues

@fabian4
Copy link
Contributor Author

fabian4 commented Oct 29, 2025

Hi @arkodg

@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from a64e3c0 to a3c69f1 Compare October 30, 2025 14:29
@zirain
Copy link
Member

zirain commented Oct 31, 2025

@fabian4 It would be better if you can move those unrelated changes to a separated PR and rebase this one after it merged.
it will keep this PR as clean as enough.

@fabian4 fabian4 mentioned this pull request Nov 3, 2025
@fabian4 fabian4 force-pushed the add_kubeapi_linter branch from a3c69f1 to 2955f2d Compare November 5, 2025 10:45
zirain
zirain previously approved these changes Nov 10, 2025
@fabian4 fabian4 force-pushed the add_kubeapi_linter branch 3 times, most recently from 87aae83 to 6c05a1e Compare November 10, 2025 15:16
@fabian4 fabian4 closed this Nov 10, 2025
@fabian4 fabian4 reopened this Nov 10, 2025
@zirain
Copy link
Member

zirain commented Nov 10, 2025

wait #7484

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from cnvergence and zirain November 15, 2025 03:21
@zirain
Copy link
Member

zirain commented Nov 15, 2025

/retest

@zirain zirain closed this Nov 15, 2025
@zirain zirain reopened this Nov 15, 2025
Signed-off-by: fabian4 <[email protected]>
@zirain zirain force-pushed the add_kubeapi_linter branch from d2cbbd9 to 576b18b Compare November 17, 2025 01:42
@zirain zirain enabled auto-merge (squash) November 17, 2025 01:42
@zirain zirain merged commit c18aa74 into envoyproxy:main Nov 17, 2025
32 checks passed
@fabian4 fabian4 deleted the add_kubeapi_linter branch November 17, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add kubeapi linter to make lint

4 participants