Skip to content

perf: avoid JSON Marshal when debug logger is disabled #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 1 commit into from
Sep 25, 2025
Merged

perf: avoid JSON Marshal when debug logger is disabled #7066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/gatewayapi/runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ func (r *Runner) subscribeAndTranslate(sub <-chan watchable.Snapshot[string, *re
// Publish the IRs.
// Also validate the ir before sending it.
for key, val := range result.InfraIR {
r.Logger.V(1).WithValues(string(message.InfraIRMessageName), key).Info(val.JSONString())
logger := r.Logger.V(1).WithValues(string(message.InfraIRMessageName), key)
if logger.Enabled() {
logger.Info(val.JSONString())
}
if err := val.Validate(); err != nil {
r.Logger.Error(err, "unable to validate infra ir, skipped sending it")
errChan <- err
Expand All @@ -206,7 +209,10 @@ func (r *Runner) subscribeAndTranslate(sub <-chan watchable.Snapshot[string, *re
}

for key, val := range result.XdsIR {
r.Logger.V(1).WithValues(string(message.XDSIRMessageName), key).Info(val.JSONString())
logger := r.Logger.V(1).WithValues(string(message.XDSIRMessageName), key)
if logger.Enabled() {
logger.Info(val.JSONString())
}
if err := val.Validate(); err != nil {
r.Logger.Error(err, "unable to validate xds ir, skipped sending it")
errChan <- err
Expand Down