Skip to content

fix: cluster stat name: lowercase Kind #6780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 1 commit into from
Aug 12, 2025
Merged

fix: cluster stat name: lowercase Kind #6780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/gatewayapi/route.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2083,7 +2083,7 @@ func getStatPattern(routeContext RouteContext, parentRef *RouteParentContext) st
func buildStatName(pattern string, route RouteContext, ruleName *gwapiv1.SectionName, idx int, refs []string) string {
statName := strings.ReplaceAll(pattern, egv1a1.StatFormatterRouteName, route.GetName())
statName = strings.ReplaceAll(statName, egv1a1.StatFormatterRouteNamespace, route.GetNamespace())
statName = strings.ReplaceAll(statName, egv1a1.StatFormatterRouteKind, route.GetObjectKind().GroupVersionKind().Kind)
statName = strings.ReplaceAll(statName, egv1a1.StatFormatterRouteKind, strings.ToLower(route.GetObjectKind().GroupVersionKind().Kind))
if ruleName == nil {
statName = strings.ReplaceAll(statName, egv1a1.StatFormatterRouteRuleName, "-")
} else {
Expand Down
6 changes: 3 additions & 3 deletions internal/gatewayapi/testdata/envoyproxy-with-statname.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ xdsIR:
name: httproute/default/httproute-1/rule/0/backend/1
protocol: HTTP
weight: 1
statName: HTTPRoute/default/httproute-1/foo/0/default/service-3|default/service-4
statName: httproute/default/httproute-1/foo/0/default/service-3|default/service-4
hostname: gateway.envoyproxy.io
isHTTP2: false
metadata:
Expand Down Expand Up @@ -262,7 +262,7 @@ xdsIR:
name: httproute/default/httproute-1/rule/1/backend/0
protocol: HTTP
weight: 1
statName: HTTPRoute/default/httproute-1/fallback/1/default/service-1
statName: httproute/default/httproute-1/fallback/1/default/service-1
hostname: gateway.envoyproxy.io
isHTTP2: false
metadata:
Expand Down Expand Up @@ -326,7 +326,7 @@ xdsIR:
name: grpcroute/default/grpcroute-1/rule/0/backend/3
protocol: GRPC
weight: 1
statName: GRPCRoute/default/grpcroute-1/-/0/default/service-1|default/service-2|default/service-3|default/service-4
statName: grpcroute/default/grpcroute-1/-/0/default/service-1|default/service-2|default/service-3|default/service-4
hostname: '*'
isHTTP2: true
metadata:
Expand Down
1 change: 1 addition & 0 deletions release-notes/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ security updates: |
new features: |

bug fixes: |
Fixed %ROUTE_KIND% operator to be lower-cased when used by clusterStatName in EnvoyProxy API.

# Enhancements that improve performance.
performance improvements: |
Expand Down