fix: http3 listener with multiple hostnames#6675
Closed
zhaohuabing wants to merge 3 commits intoenvoyproxy:mainfrom
Closed
fix: http3 listener with multiple hostnames#6675zhaohuabing wants to merge 3 commits intoenvoyproxy:mainfrom
zhaohuabing wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6675 +/- ##
==========================================
- Coverage 71.10% 71.07% -0.03%
==========================================
Files 225 225
Lines 39760 39779 +19
==========================================
+ Hits 28271 28273 +2
- Misses 9829 9843 +14
- Partials 1660 1663 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
can we scope this logic to http3 only ? |
Member
Author
Could you be more specific? I think this PR only includes necessary code changes to make HTTP3 listener work. |
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Contributor
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLSInspector doesn't work for UDP, so for HTTP3 xDS listener, we should use the default filter chain and create a default route for multiple ir HTTPListeners with different hostnames on the same port.
fixes: #5660 (comment)
Caveat: Since listeners with different hostnames are merged into the default filter chain, they can only share a single wildcard server certificate if HTTP3 is enabled. Currently, this is not checked and one of the certs is used for HTTP3 listener. We should enforce this restriction and surface an error to the ClientTrafficPolicy.