-
Notifications
You must be signed in to change notification settings - Fork 708
API: add runtime guards for risky behavior changes to EnvoyGateway #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,6 +93,28 @@ type EnvoyGatewaySpec struct { | |
| // | ||
| // +optional | ||
| ExtensionAPIs *ExtensionAPISettings `json:"extensionApis,omitempty"` | ||
|
|
||
| // RuntimeFlags defines the runtime flags for Envoy Gateway. | ||
| // Unlike ExtensionAPIs, these flags are temporary and will be removed in future releases once the related features are stable. | ||
| RuntimeFlags *RuntimeFlags `json:"runtimeFlags,omitempty"` | ||
| } | ||
|
|
||
| // RuntimeFlag defines a runtime flag used to guard breaking changes or risky experimental features in new Envoy Gateway releases. | ||
| // A runtime flag may be enabled or disabled by default and can be toggled through the EnvoyGateway resource. | ||
| type RuntimeFlag string | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we add a validation tag here
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh sorry I misunderstood your comment - will add it in the implementation PR. |
||
|
|
||
| const ( | ||
| // UseAddressAsListenerName indicates that the listener name should be derived from the address and port. | ||
| UseAddressAsListenerName RuntimeFlag = "UseAddressAsListenerName" | ||
| ) | ||
|
|
||
| // RuntimeFlags provide a mechanism to guard breaking changes or risky experimental features in new Envoy Gateway releases. | ||
| // Each flag may be enabled or disabled by default and can be toggled through the EnvoyGateway resource. | ||
| // The names of these flags will be included in the release notes alongside an explanation of the change. | ||
| // Please note that these flags are temporary and will be removed in future releases once the related features are stable. | ||
| type RuntimeFlags struct { | ||
| Enabled []RuntimeFlag `json:"enabled,omitempty"` | ||
| Disabled []RuntimeFlag `json:"disabled,omitempty"` | ||
| } | ||
|
|
||
| type KubernetesClient struct { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1