e2e: use appropriate values for upgrade test#6409
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Jun 26, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6409 +/- ##
=======================================
Coverage 70.83% 70.83%
=======================================
Files 220 220
Lines 37157 37157
=======================================
+ Hits 26319 26321 +2
+ Misses 9292 9291 -1
+ Partials 1546 1545 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zirain <zirain2009@gmail.com>
shawnh2
approved these changes
Jun 26, 2025
Member
|
Looks like a regression here, can you elaborate why the different values will cause e2e failures? |
Member
Author
|
flaky happen frequently when qps ≥ 4000. |
guydc
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #6035 #6009