fix: fix validation errors that occur when the redis url contains valid sentinel or cluster config#6394
Merged
arkodg merged 9 commits intoenvoyproxy:mainfrom Jul 3, 2025
Merged
Conversation
…hosts. Signed-off-by: keithfz <kzeto4@gmail.com>
Signed-off-by: keithfz <kzeto4@gmail.com>
Signed-off-by: keithfz <kzeto4@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6394 +/- ##
==========================================
- Coverage 70.92% 70.90% -0.03%
==========================================
Files 220 220
Lines 37260 37262 +2
==========================================
- Hits 26428 26420 -8
- Misses 9285 9294 +9
- Partials 1547 1548 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Keith <kzeto4@gmail.com>
Member
|
/retest |
arkodg
approved these changes
Jul 3, 2025
tjvdmolen
pushed a commit
to tjvdmolen/gateway
that referenced
this pull request
Jul 11, 2025
…id sentinel or cluster config (envoyproxy#6394) * Update redis url validations to accept comma delimited list of names/hosts. Signed-off-by: keithfz <kzeto4@gmail.com> Signed-off-by: Tjeerd Jan van der Molen <34071+tjvdmolen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixes validation errors that occur when the Redis URL contains "valid" sentinel or cluster configurations.
What this PR does / why we need it:
There are three modes of deployment for Redis that are also compatible with the rate limit service. They each have a slightly different format under the url configuration field.
-,., and_.This splits the url string by commas, and then validates all returned items in the list. This way, Sentinel and Cluster configurations are also considered valid, and do not need work-arounds that obfuscate the actual configuration.
Which issue(s) this PR fixes:
Fixes #5086
Release Notes: Yes