Skip to content

e2e: fix DynamicResolverBackend test#6374

Merged
shawnh2 merged 2 commits intoenvoyproxy:mainfrom
zirain:e2e/DynamicResolverBackend
Jun 23, 2025
Merged

e2e: fix DynamicResolverBackend test#6374
shawnh2 merged 2 commits intoenvoyproxy:mainfrom
zirain:e2e/DynamicResolverBackend

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jun 22, 2025

xref: #6194

@zirain zirain requested a review from a team as a code owner June 22, 2025 09:15
@codecov
Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (fe22706) to head (64e6f91).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6374      +/-   ##
==========================================
+ Coverage   70.69%   70.72%   +0.03%     
==========================================
  Files         220      220              
  Lines       37089    37089              
==========================================
+ Hits        26220    26233      +13     
+ Misses       9327     9317      -10     
+ Partials     1542     1539       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the e2e/DynamicResolverBackend branch from 2ebf3a4 to 931faf2 Compare June 22, 2025 12:17
Signed-off-by: zirain <zirain2009@gmail.com>
kind: Backend
name: backend-dynamic-resolver-with-app-protocol
match:
matches:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this never work.

@zirain zirain changed the title e2e: minor fix for DynamicResolverBackend test e2e: fix DynamicResolverBackend test Jun 22, 2025
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@shawnh2 shawnh2 merged commit ddc9a5c into envoyproxy:main Jun 23, 2025
28 checks passed
@zirain zirain deleted the e2e/DynamicResolverBackend branch June 23, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants