Skip to content

bugfix: make EnvoyPatchPolicy able to replace telemetry cluster#6367

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:epp-replace-cluster
Jun 21, 2025
Merged

bugfix: make EnvoyPatchPolicy able to replace telemetry cluster#6367
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:epp-replace-cluster

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jun 21, 2025

No description provided.

@zirain zirain requested a review from a team as a code owner June 21, 2025 02:13
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested a review from zhaohuabing June 21, 2025 02:16
@zirain
Copy link
Member Author

zirain commented Jun 21, 2025

@arkodg need to backport

@codecov
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.71%. Comparing base (db09d27) to head (226d253).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6367      +/-   ##
==========================================
- Coverage   70.73%   70.71%   -0.03%     
==========================================
  Files         220      220              
  Lines       37096    37096              
==========================================
- Hits        26241    26233       -8     
- Misses       9314     9322       +8     
  Partials     1541     1541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the epp-replace-cluster branch from 026031e to 226d253 Compare June 21, 2025 03:30
@zirain zirain enabled auto-merge (squash) June 21, 2025 03:36
@arkodg arkodg disabled auto-merge June 21, 2025 05:15
@arkodg arkodg merged commit e1c0474 into envoyproxy:main Jun 21, 2025
26 of 28 checks passed
@zirain zirain deleted the epp-replace-cluster branch June 21, 2025 06:56
shawnh2 pushed a commit to shawnh2/gateway that referenced this pull request Jul 2, 2025
…yproxy#6367)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zhaohuabing added a commit that referenced this pull request Jul 4, 2025
* fix(translator): ext-proc full duplex streamed trailers and validation (#6323)
* fix ext proc validation and trailer management for full duplex streamed mode

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* feat: disable automountServiceAccountToken for proxy and ratelimit (#6364)

Signed-off-by: Jeff Davis <mr.jefedavis@gmail.com>

* bugfix: make EnvoyPatchPolicy able to replace telemetry cluster (#6367)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* feat: add validation of section name for Gateway listener (#6343)

* add validation of section name

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

* update error status reason

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

* refactor: define as function of validate section name for gateway listener

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix: add configMap indexers for EEP reconciler (#6369)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: use buildEndpointType for access and tracing (#6370)

Signed-off-by: zirain <zirain2009@gmail.com>

* fix: default accesslog not working (#6441)
* fix default accesslog

Signed-off-by: zirain <zirain2009@gmail.com>

* release notes

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* chore: fix cve (#6446)

* fix cve

Signed-off-by: zirain <zirain2009@gmail.com>

* lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>

* fix: Do not set backendRequestTimeout when Retries are set (#6421)

* fix: Do not set backendRequestTimeout when Retries are set

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>

* fix: update comment

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>

---------

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>

* gatewayapi: don't append gwcResource if there's invalid GatewayClass (#6379)

* gatewayapi: don't process gloabal resources when acceptedGateways is 0

Signed-off-by: zirain <zirain2009@gmail.com>

* update

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* don't skip gateways

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix testdata

Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix k8s provider controller

Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix: retry reconcile on transient errors during reconcile  (#6299)

* fix: add isTransientError helper to classify retryable errors

Introduces isTransientError to detect transient Kubernetes errors and
enable proper reconciliation retries.

Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>

handle errors from processing BackendRefs

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

handle errors from processing ConfigMap

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* skip invalid GatewayClass

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* address comment

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* handle all transient errors

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* don't skip failed GCs

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 71ce56f)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix: fix bug in hostname overlap detection (#6332)

fix bug in hostname overlap detection

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
(cherry picked from commit e78e268)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix telemetry with host port not working (#6460)

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit c0a2ce7)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* bugfix: BackendTlsPolicy should not reference across namespace (#6309)

* bugfix: BackendTlsPolicy should not reference across namespace

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 9925189)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Jeff Davis <mr.jefedavis@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Guy Daich <guy.daich@sap.com>
Co-authored-by: Jeff Davis <mr.jefedavis@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
Co-authored-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Co-authored-by: Sudipto Baral <sudiptobaral.me@gmail.com>
Co-authored-by: Patryk Rostkowski <48490105+patrostkowski@users.noreply.github.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
shawnh2 added a commit to shawnh2/gateway that referenced this pull request Sep 15, 2025
* fix(translator): ext-proc full duplex streamed trailers and validation (envoyproxy#6323)
* fix ext proc validation and trailer management for full duplex streamed mode

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* feat: disable automountServiceAccountToken for proxy and ratelimit (envoyproxy#6364)

Signed-off-by: Jeff Davis <mr.jefedavis@gmail.com>

* bugfix: make EnvoyPatchPolicy able to replace telemetry cluster (envoyproxy#6367)

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* feat: add validation of section name for Gateway listener (envoyproxy#6343)

* add validation of section name

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

* update error status reason

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

* refactor: define as function of validate section name for gateway listener

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix: add configMap indexers for EEP reconciler (envoyproxy#6369)

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: use buildEndpointType for access and tracing (envoyproxy#6370)

Signed-off-by: zirain <zirain2009@gmail.com>

* fix: default accesslog not working (envoyproxy#6441)
* fix default accesslog

Signed-off-by: zirain <zirain2009@gmail.com>

* release notes

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* chore: fix cve (envoyproxy#6446)

* fix cve

Signed-off-by: zirain <zirain2009@gmail.com>

* lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>

* fix: Do not set backendRequestTimeout when Retries are set (envoyproxy#6421)

* fix: Do not set backendRequestTimeout when Retries are set

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>

* fix: update comment

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>

---------

Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>

* gatewayapi: don't append gwcResource if there's invalid GatewayClass (envoyproxy#6379)

* gatewayapi: don't process gloabal resources when acceptedGateways is 0

Signed-off-by: zirain <zirain2009@gmail.com>

* update

Signed-off-by: zirain <zirain2009@gmail.com>

* fix test

Signed-off-by: zirain <zirain2009@gmail.com>

* don't skip gateways

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix testdata

Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix k8s provider controller

Signed-off-by: shawnh2 <shawnhxh@outlook.com>

* fix: retry reconcile on transient errors during reconcile  (envoyproxy#6299)

* fix: add isTransientError helper to classify retryable errors

Introduces isTransientError to detect transient Kubernetes errors and
enable proper reconciliation retries.

Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>

handle errors from processing BackendRefs

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

handle errors from processing ConfigMap

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* skip invalid GatewayClass

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* address comment

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* handle all transient errors

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* don't skip failed GCs

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 71ce56f)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix: fix bug in hostname overlap detection (envoyproxy#6332)

fix bug in hostname overlap detection

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
(cherry picked from commit e78e268)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* fix telemetry with host port not working (envoyproxy#6460)

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit c0a2ce7)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

* bugfix: BackendTlsPolicy should not reference across namespace (envoyproxy#6309)

* bugfix: BackendTlsPolicy should not reference across namespace

Signed-off-by: zirain <zirain2009@gmail.com>
(cherry picked from commit 9925189)
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Jeff Davis <mr.jefedavis@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: Patryk Rostkowski <patrostkowski@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Guy Daich <guy.daich@sap.com>
Co-authored-by: Jeff Davis <mr.jefedavis@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
Co-authored-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Co-authored-by: Sudipto Baral <sudiptobaral.me@gmail.com>
Co-authored-by: Patryk Rostkowski <48490105+patrostkowski@users.noreply.github.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants