feat: allow deployment annotations to be added through helm#6341
Merged
zirain merged 13 commits intoenvoyproxy:mainfrom Jul 2, 2025
Merged
feat: allow deployment annotations to be added through helm#6341zirain merged 13 commits intoenvoyproxy:mainfrom
zirain merged 13 commits intoenvoyproxy:mainfrom
Conversation
lboynton
force-pushed
the
helm-deployment-annotations
branch
2 times, most recently
from
0041ccd to
3114532
Compare
Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
zirain
force-pushed
the
helm-deployment-annotations
branch
from
cf0e181 to
5c7a96d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6341 +/- ##
==========================================
+ Coverage 70.90% 70.92% +0.01%
==========================================
Files 220 220
Lines 37263 37263
==========================================
+ Hits 26422 26427 +5
+ Misses 9298 9291 -7
- Partials 1543 1545 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lboynton
force-pushed
the
helm-deployment-annotations
branch
from
7f02ec1 to
0f4ea6a
Compare
Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
lboynton
force-pushed
the
helm-deployment-annotations
branch
from
0f4ea6a to
e2a8b46
Compare
zirain
previously approved these changes
Jun 29, 2025
Contributor
|
thanks @lboynton can you also add a test to https://github.com/envoyproxy/gateway/tree/main/test/helm/gateway-helm |
…ations # Conflicts: # release-notes/current.yaml
Contributor
Author
Added a test, not too sure how to run it locally 😄 |
Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
…nto helm-deployment-annotations
Contributor
Author
|
Test should hopefully pass now 🙂 |
zirain
approved these changes
Jul 2, 2025
cnvergence
approved these changes
Jul 2, 2025
tjvdmolen
pushed a commit
to tjvdmolen/gateway
that referenced
this pull request
Jul 11, 2025
…xy#6341) * feat: allow deployment annotations to be added through helm Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> * Update changelog Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> * Update readme values Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> * update readme Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> * add test Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> * fix test, order is important Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> --------- Signed-off-by: Lee Boynton <lee.boynton@truelayer.com> Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: Tjeerd Jan van der Molen <34071+tjvdmolen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: allow deployment annotations to be added through helm
What this PR does / why we need it:
Makes it possible to add annotations to the deployment that the gateway helm chart creates.
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes