Skip to content

feat: load certs fallback to first key#6327

Merged
zirain merged 4 commits intoenvoyproxy:mainfrom
zirain:load-cacert
Jun 19, 2025
Merged

feat: load certs fallback to first key#6327
zirain merged 4 commits intoenvoyproxy:mainfrom
zirain:load-cacert

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jun 17, 2025

Fallback to the first key when ca.crt is not found, similar to what we did in custom response body.

@zirain zirain requested a review from a team as a code owner June 17, 2025 01:45
@zirain zirain force-pushed the load-cacert branch 2 times, most recently from c274cf8 to 49c7e4a Compare June 17, 2025 01:53
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (e78e268) to head (02dc923).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6327      +/-   ##
==========================================
+ Coverage   70.67%   70.70%   +0.02%     
==========================================
  Files         220      220              
  Lines       37003    37029      +26     
==========================================
+ Hits        26153    26181      +28     
+ Misses       9312     9311       -1     
+ Partials     1538     1537       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zirain added 3 commits June 18, 2025 07:37
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from arkodg June 17, 2025 23:44
arkodg
arkodg previously approved these changes Jun 19, 2025
@arkodg arkodg requested review from a team June 19, 2025 00:54
@arkodg arkodg requested review from a team June 19, 2025 01:00
@zirain zirain merged commit 16747d4 into envoyproxy:main Jun 19, 2025
45 of 47 checks passed
@zirain zirain deleted the load-cacert branch June 19, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants