feat: load certs fallback to first key#6327
Merged
zirain merged 4 commits intoenvoyproxy:mainfrom Jun 19, 2025
Merged
Conversation
c274cf8 to
49c7e4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6327 +/- ##
==========================================
+ Coverage 70.67% 70.70% +0.02%
==========================================
Files 220 220
Lines 37003 37029 +26
==========================================
+ Hits 26153 26181 +28
+ Misses 9312 9311 -1
+ Partials 1538 1537 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Jun 17, 2025
arkodg
reviewed
Jun 17, 2025
arkodg
previously approved these changes
Jun 19, 2025
arkodg
approved these changes
Jun 19, 2025
rudrakhp
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback to the first key when
ca.crtis not found, similar to what we did in custom response body.