Skip to content

chore: fix unnecessary type arguments lint#6306

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
cnvergence:chore-typearguments
Jun 13, 2025
Merged

chore: fix unnecessary type arguments lint#6306
arkodg merged 2 commits intoenvoyproxy:mainfrom
cnvergence:chore-typearguments

Conversation

@cnvergence
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence marked this pull request as ready for review June 13, 2025 11:03
@cnvergence cnvergence requested a review from a team as a code owner June 13, 2025 11:03
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.63%. Comparing base (c5835dd) to head (ad7e684).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 35.29% 5 Missing and 17 partials ⚠️

❌ Your patch status has failed because the patch coverage (35.29%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6306      +/-   ##
==========================================
+ Coverage   70.61%   70.63%   +0.02%     
==========================================
  Files         220      220              
  Lines       36829    36829              
==========================================
+ Hits        26006    26014       +8     
+ Misses       9291     9282       -9     
- Partials     1532     1533       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain
Copy link
Member

zirain commented Jun 13, 2025

can we have a linter for this?

@cnvergence
Copy link
Member Author

cnvergence commented Jun 13, 2025

I tried to look for it :(
it's coming from gopls

@arkodg arkodg merged commit 7899aaf into envoyproxy:main Jun 13, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants