feat(api): allow pinning custom image repository for Envoy Proxy.#6296
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6296 +/- ##
==========================================
+ Coverage 70.57% 70.60% +0.03%
==========================================
Files 220 220
Lines 36829 36859 +30
==========================================
+ Hits 25993 26026 +33
+ Misses 9299 9298 -1
+ Partials 1537 1535 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sudiptob2
force-pushed
the
feat/6066/image-repo-in-kube-provider
branch
2 times, most recently
from
c307510 to
56bb6c3
Compare
api/v1alpha1/shared_types.go
Outdated
There was a problem hiding this comment.
Can we change this message to something more meaningful like "only one of image or imageRepository can be set"
There was a problem hiding this comment.
Updated with simpler wording.
api/v1alpha1/shared_types.go
Outdated
There was a problem hiding this comment.
Can we add a cel test for this?
There was a problem hiding this comment.
Added test for CEL validation
There was a problem hiding this comment.
Should we have any validation in place to ensure user is not passing a tag in imageRepository?
There was a problem hiding this comment.
Yeah, a validation could be useful, but in my opinion, it's redundant. There are many ways an imageRepository string can be invalid—not just tag. Also, the image field doesn’t currently validate whether a tag is present. So, I think we can skip this validation in this case as well.
There was a problem hiding this comment.
good to track this with a GH issue, so we dont forget about general image validation
sudiptob2
force-pushed
the
feat/6066/image-repo-in-kube-provider
branch
4 times, most recently
from
5d45703 to
8885a89
Compare
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
sudiptob2
force-pushed
the
feat/6066/image-repo-in-kube-provider
branch
from
e4a043a to
cd5f962
Compare
3 participants
This PR allows users to specify a custom image repository for EnvoyProxy without needing to provide a tag.
Fixes #6066
Release Notes: No