Update gateway-api-metrics.md#6283
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Jun 10, 2025
Merged
Conversation
Link to Gateway Exported Metrics updated in Next Steps Signed-off-by: Saurab Tharu <54340090+saurabtharu@users.noreply.github.com>
cnvergence
requested changes
Jun 10, 2025
Member
cnvergence
left a comment
cnvergence
left a comment
There was a problem hiding this comment.
Thanks, can you fix this link for the latest version of the docs?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6283 +/- ##
=======================================
Coverage 70.49% 70.50%
=======================================
Files 220 220
Lines 36639 36639
=======================================
+ Hits 25830 25831 +1
Misses 9281 9281
+ Partials 1528 1527 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shawnh2
reviewed
Jun 10, 2025
Contributor
shawnh2
left a comment
shawnh2
left a comment
There was a problem hiding this comment.
Can you also update the latest doc?
Changes in Link to Gateway Exported Metrics updated in Next Step in `Latest` version of the doc Signed-off-by: Saurab Tharu <54340090+saurabtharu@users.noreply.github.com>
Contributor
Author
Sure, I have made pull request for |
cnvergence
approved these changes
Jun 10, 2025
zirain
approved these changes
Jun 10, 2025
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Gateway Exported Metrics updated in Next Steps
What type of PR is this?
Doc fixes: There was a link stating "Check out the Gateway Exported Metrics" in Next Steps but it was redirecting to Grafana Integration documentaion.
What this PR does / why we need it:
This PR updates the link to correct page i.e. Gateway Exported Metrics instead of Grafana Integration
Which issue(s) this PR fixes:
Just a docs mistake
Release Notes: Yes/No
NO