Skip to content

fix: add optional flag for hostname fix #6278#6279

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
yyadavalli:fix-6278
Jun 9, 2025
Merged

fix: add optional flag for hostname fix #6278#6279
arkodg merged 1 commit intoenvoyproxy:mainfrom
yyadavalli:fix-6278

Conversation

@yyadavalli
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #6278

Release Notes: Yes/No

@yyadavalli yyadavalli requested a review from a team as a code owner June 9, 2025 19:21
@yyadavalli yyadavalli changed the title fix: Fix #6278 add optional flag for hostname fix: add optional flag for hostname fix #6278 Jun 9, 2025
@arkodg
Copy link
Contributor

arkodg commented Jun 9, 2025

@yyadavalli above tag may not be used in docs, you may need to use // +optional to populate the docs column

@yyadavalli
Copy link
Contributor Author

@yyadavalli above tag may not be used in docs, you may need to use // +optional to populate the docs column

Ack, will use the other tag

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (402cd99) to head (9d4e088).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6279      +/-   ##
==========================================
- Coverage   70.52%   70.49%   -0.03%     
==========================================
  Files         220      220              
  Lines       36639    36639              
==========================================
- Hits        25838    25828      -10     
- Misses       9276     9282       +6     
- Partials     1525     1529       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Yashwanth Yadavalli <yashwanth.yadavalli@protonmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team June 9, 2025 20:20
@arkodg arkodg merged commit 598c813 into envoyproxy:main Jun 9, 2025
29 checks passed
@yyadavalli yyadavalli deleted the fix-6278 branch June 9, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hostname should not be required in HTTPActiveHealthChecker

4 participants