feat: add gatewayclass ownerreference to infra resources when all cases except gateway namespace mode#6238
Merged
arkodg merged 7 commits intoenvoyproxy:mainfrom Jun 11, 2025
Merged
Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6238 +/- ##
=======================================
Coverage 70.56% 70.56%
=======================================
Files 220 220
Lines 36755 36771 +16
=======================================
+ Hits 25936 25949 +13
- Misses 9287 9291 +4
+ Partials 1532 1531 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I've got a question on OwnerRefrence on GatewayClass instead of Gateway: #3051 (comment) @arkodg |
zirain
previously approved these changes
Jun 11, 2025
Member
zirain
left a comment
zirain
left a comment
There was a problem hiding this comment.
LGTM, please fix the conflict.
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Member
Author
|
thanks for review. |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up #6100
Set Gatewayclass ownerreference to infra resources.
This PR makes it possible to set ownerReferences to infra resources in all deployment scenario.
Which issue(s) this PR fixes:
Fixes #3051
Release Notes: Yes