feat: Add support for configuring maxConnectionsToAcceptPerSocketEvent in ClientTrafficPolicy#6233
Merged
rudrakhp merged 23 commits intoenvoyproxy:mainfrom Jun 21, 2025
Merged
Conversation
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
jukie
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6233 +/- ##
==========================================
+ Coverage 70.72% 70.76% +0.03%
==========================================
Files 220 220
Lines 37096 37103 +7
==========================================
+ Hits 26236 26255 +19
+ Misses 9320 9310 -10
+ Partials 1540 1538 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
rudrakhp
reviewed
May 30, 2025
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
rudrakhp
previously approved these changes
May 30, 2025
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Signed-off-by: Isaac <10012479+jukie@users.noreply.github.com>
rudrakhp
reviewed
Jun 3, 2025
Member
rudrakhp
left a comment
rudrakhp
left a comment
There was a problem hiding this comment.
Minor suggestion, rest LGTM!
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Contributor
Author
|
/retest |
rudrakhp
previously approved these changes
Jun 3, 2025
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
approved these changes
Jun 13, 2025
Member
|
/retest |
Member
|
/retest |
Contributor
Author
|
/retest |
zirain
approved these changes
Jun 21, 2025
Member
|
/retest |
Member
|
/retest |
Contributor
|
@jukie is the use case to set it to 1 ? |
This was referenced Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: Add support for configuring
maxConnectionsToAcceptPerSocketEventin Envoy listener and set default to 1What this PR does / why we need it:
Under high load the default
maxConnectionsToAcceptPerSocketEventcould cause performance issues (ref envoyproxy/envoy#19103 (comment)). It's recommended to configure a limit vs the default unlimited and a value of 1 can be safely applied without impact.Which issue(s) this PR fixes:
Fixes #6232
Release Notes: Yes