Skip to content

docs: fix tls customisation minVersion case#6212

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
Dean-Coakley:fix-backend-tls-tutorial
May 29, 2025
Merged

docs: fix tls customisation minVersion case#6212
arkodg merged 1 commit intoenvoyproxy:mainfrom
Dean-Coakley:fix-backend-tls-tutorial

Conversation

@Dean-Coakley
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

  • Without it the tls minVersion spec does not cleanly apply when applying from a file
Error from server (BadRequest): error when creating "custom.yaml": EnvoyProxy in version "v1alpha1" cannot be handled as a EnvoyProxy: strict decoding error: unknown field "spec.backendTLS.MinVersion"

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@Dean-Coakley Dean-Coakley requested a review from a team as a code owner May 28, 2025 17:14
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (845b36b) to head (a43c5d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6212      +/-   ##
==========================================
+ Coverage   70.46%   70.50%   +0.03%     
==========================================
  Files         220      220              
  Lines       36593    36593              
==========================================
+ Hits        25787    25800      +13     
+ Misses       9281     9271      -10     
+ Partials     1525     1522       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team May 28, 2025 20:23
@zirain
Copy link
Member

zirain commented May 28, 2025

please fix DCO

Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
@Dean-Coakley Dean-Coakley force-pushed the fix-backend-tls-tutorial branch from d59f44b to a43c5d8 Compare May 29, 2025 08:55
@arkodg arkodg merged commit 34a327b into envoyproxy:main May 29, 2025
28 of 30 checks passed
@Dean-Coakley Dean-Coakley deleted the fix-backend-tls-tutorial branch May 29, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants