dump config for flaky dynamic resover test#6196
Merged
zhaohuabing merged 3 commits intoenvoyproxy:mainfrom May 28, 2025
Merged
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zirain
previously approved these changes
May 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6196 +/- ##
==========================================
- Coverage 70.61% 70.59% -0.03%
==========================================
Files 219 219
Lines 36515 36515
==========================================
- Hits 25786 25778 -8
- Misses 9201 9208 +7
- Partials 1528 1529 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zirain
reviewed
May 27, 2025
| }, | ||
| } | ||
|
|
||
| var DynamicResolverBackendWithTLSTest = suite.ConformanceTest{ |
Member
There was a problem hiding this comment.
QQ: why split them into two test? They should be able run in same test for short time cost.
Member
Author
There was a problem hiding this comment.
It would be easier to debug the flaky when running the non-TLS and TLS in different tests - they didn't fail at the same time in the previous flaky tests.
zirain
approved these changes
May 28, 2025
cnvergence
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dump config to debug #6194