Skip to content

ci: fix go.test.cel#6185

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:ci/go.test.cel
May 26, 2025
Merged

ci: fix go.test.cel#6185
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:ci/go.test.cel

Conversation

@zirain
Copy link
Member

@zirain zirain commented May 25, 2025

fixes: #6184

@zirain zirain requested a review from a team as a code owner May 25, 2025 12:29
Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Member

@rudrakhp rudrakhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zirain you will probably also have to fix the unix path length test failing for CI to pass

Signed-off-by: zirain <zirain2009@gmail.com>
@codecov
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.60%. Comparing base (b18e5b6) to head (84f21fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6185      +/-   ##
==========================================
- Coverage   70.61%   70.60%   -0.02%     
==========================================
  Files         219      219              
  Lines       36453    36500      +47     
==========================================
+ Hits        25742    25769      +27     
- Misses       9186     9200      +14     
- Partials     1525     1531       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rudrakhp
Copy link
Member

/retest

// The path length must not exceed 108 characters.
//
// +kubebuilder:validation:MaxLength=108
// +kubebuilder:validation:XValidation:rule="size(self) <= 108",message="unix domain socket path must not exceed 108 characters"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prev implement cause unexpected error:

The Backend "backend-unix" is invalid:
* spec.endpoints[0].unix.path: Too long: may not be more than 108 bytes
* <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

@zirain zirain merged commit f392bc5 into envoyproxy:main May 26, 2025
59 of 63 checks passed
@zirain zirain deleted the ci/go.test.cel branch May 26, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CEL tests failing doesn't fail coverage tests

3 participants