use SDS for the client cert for connections with Wasm HTTP server#6139
Merged
zhaohuabing merged 3 commits intoenvoyproxy:mainfrom May 23, 2025
Merged
use SDS for the client cert for connections with Wasm HTTP server#6139zhaohuabing merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing merged 3 commits intoenvoyproxy:mainfrom
Conversation
zhaohuabing
force-pushed
the
fix-gatewaynamespace-wasm
branch
2 times, most recently
from
8fe0e05 to
7453e70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6139 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 219 219
Lines 36406 36444 +38
=======================================
+ Hits 25695 25722 +27
- Misses 9186 9193 +7
- Partials 1525 1529 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
force-pushed
the
fix-gatewaynamespace-wasm
branch
from
7453e70 to
d1a7004
Compare
zirain
force-pushed
the
fix-gatewaynamespace-wasm
branch
from
6b6aeda to
e38857c
Compare
Contributor
|
since this change also affects non gateway mode users, maybe its safer to do this as a minor release than patch release |
zirain
previously approved these changes
May 23, 2025
cnvergence
previously approved these changes
May 23, 2025
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zirain
force-pushed
the
fix-gatewaynamespace-wasm
branch
from
e38857c to
1071487
Compare
zhaohuabing
dismissed stale reviews from zirain, arkodg, and cnvergence
via
ca91036
zirain
approved these changes
May 23, 2025
cnvergence
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses SDS to fetch the envoy client certificate for envoy-wasm HTTP server TLS connection, and enables Wasm e2e tests for gatewaynamepace mode.