Use gateway name as Proxy fleet name for Gateway Namespace mode

[zirain]

fixes: #6131

[codecov]

Codecov Report

Attention: Patch coverage is 66.07143% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (f89ca94) to head (c0e4868).
Report is 29 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/xds/server/kubejwt/tokenreview.go	0.00%	15 Missing ⚠️
internal/xds/server/kubejwt/jwtinterceptor.go	0.00%	3 Missing ⚠️
internal/xds/server/runner/runner.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6135      +/-   ##
==========================================
- Coverage   70.62%   70.58%   -0.04%     
==========================================
  Files         219      219              
  Lines       36500    36511      +11     
==========================================
- Hits        25777    25772       -5     
- Misses       9195     9210      +15     
- Partials     1528     1529       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arkodg]

ha, can we decorate this with comments, mentioning that we need the IR key here to set in serviceCluster

another option is to pass the IR key into

gateway/internal/infrastructure/runner/runner.go

Line 115 in be51e5b

if err := r.mgr.CreateOrUpdateProxyInfra(ctx, val); err != nil {

and eventually pass the context here ?

[zirain]

the root cause there's two type thing in this name field

• In controller namspace mode, it's ns/name (equal to irKey)
• In gateway namespace mode, it's just the name.

we'd better clean this in a follow up PR.

[arkodg]

can we avoid this ? looks like its following alphabetical order ?

[zirain]

Before, it's hand made. Now it's part of make go.testdata.complete, which is better IMO.

[arkodg]

LGTM thanks !
added one comment