feat(translator): support active http healthcheck host#6118
Merged
guydc merged 4 commits intoenvoyproxy:mainfrom May 26, 2025
Merged
feat(translator): support active http healthcheck host#6118guydc merged 4 commits intoenvoyproxy:mainfrom
guydc merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6118 +/- ##
==========================================
- Coverage 70.61% 70.57% -0.05%
==========================================
Files 219 219
Lines 36453 36456 +3
==========================================
- Hits 25742 25729 -13
- Misses 9186 9197 +11
- Partials 1525 1530 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
approved these changes
May 23, 2025
zhaohuabing
approved these changes
May 26, 2025
cnvergence
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Makes it possible to configure the hostname for active HTTP healthchecks, when the host header should be different from the incoming hostname of the xRoute.
Which issue(s) this PR fixes:
Fixes #6116
Release Notes: Yes