fix: ZoneAwareRouting not working GNM(gateway namespace mode)#6107
Merged
zirain merged 3 commits intoenvoyproxy:mainfrom May 19, 2025
Merged
fix: ZoneAwareRouting not working GNM(gateway namespace mode)#6107zirain merged 3 commits intoenvoyproxy:mainfrom
zirain merged 3 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6107 +/- ##
==========================================
+ Coverage 70.42% 70.52% +0.10%
==========================================
Files 217 217
Lines 36181 36191 +10
==========================================
+ Hits 25480 25525 +45
+ Misses 9182 9153 -29
+ Partials 1519 1513 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
reviewed
May 19, 2025
test/helm/gateway-helm/envoy-gateway-gateway-namespace-config-watch.out.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
gateway-namespace-mode/ZoneAwareRouting
branch
from
0abb145 to
5972cf9
Compare
cnvergence
approved these changes
May 19, 2025
arkodg
reviewed
May 19, 2025
| values: | ||
| - {{ .Release.Namespace }} | ||
| {{- else if gt (len $watchedNamespaces) 0 }} | ||
| namespaceSelector: |
Contributor
There was a problem hiding this comment.
there is an issue with this approach, with multiple envoy-gateway running in 1 cluster, there's no way to decide which special web hook server to call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
namespaceSelectorinMutatingWebhookConfigurationwhen enabling GNM.