Skip to content

Fix shared=true when no clientSelector,#6072

Merged
arkodg merged 15 commits into
envoyproxy:mainfrom
ryanhristovski:fix-no-clientselector-rl-and-domain-issue
May 27, 2025
Merged

Fix shared=true when no clientSelector,#6072
arkodg merged 15 commits into
envoyproxy:mainfrom
ryanhristovski:fix-no-clientselector-rl-and-domain-issue

merge conflict fixes

793224b
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded May 27, 2025 in 0s

70.57% (target 60.00%)

View this Pull Request on Codecov

70.57% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (cbb5381) to head (793224b).

Files with missing lines Patch % Lines
internal/xds/translator/ratelimit.go 97.95% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6072      +/-   ##
==========================================
- Coverage   70.61%   70.57%   -0.05%     
==========================================
  Files         219      219              
  Lines       36515    36487      -28     
==========================================
- Hits        25786    25750      -36     
- Misses       9201     9210       +9     
+ Partials     1528     1527       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.