fix: custom controller namespace refs in gateway namespace mode#6065
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom May 14, 2025
Merged
fix: custom controller namespace refs in gateway namespace mode#6065zirain merged 1 commit intoenvoyproxy:mainfrom
zirain merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
fix-sa-audience
branch
from
e0f320b to
a73d9e4
Compare
cnvergence
commented
May 14, 2025
| @@ -636,10 +637,10 @@ func (i *Infra) getEnvoyGatewayCA(ctx context.Context) string { | |||
| secret := &corev1.Secret{} | |||
| err := i.Client.Get(ctx, types.NamespacedName{ | |||
| Name: "envoy", | |||
Member
Author
There was a problem hiding this comment.
note: we also hardcode the name when creating the secrets
zhaohuabing
approved these changes
May 14, 2025
Member
zhaohuabing
left a comment
zhaohuabing
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Should we add e2e tests for customized controller namespace to prevent regressions? @envoyproxy/gateway-maintainers
Member
Author
|
/retest |
zirain
approved these changes
May 14, 2025
cnvergence
added a commit
to cnvergence/gateway
that referenced
this pull request
May 14, 2025
…yproxy#6065) Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6065 +/- ##
==========================================
+ Coverage 70.38% 70.41% +0.02%
==========================================
Files 217 217
Lines 36171 36171
==========================================
+ Hits 25458 25468 +10
+ Misses 9191 9182 -9
+ Partials 1522 1521 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shawnh2
pushed a commit
to shawnh2/gateway
that referenced
this pull request
Sep 15, 2025
…pace mode (envoyproxy#6067) fix: custom controller namespace refs in gateway namespace mode (envoyproxy#6065) Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: shawnh2 <shawnhxh@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Changes between #5937 and #5871 weren't properly synced.
Which issue(s) this PR fixes:
Fixes #6064
Release Notes: Yes/No